Re: [PATCH v2 2/2] nvmet: preserve controller serial number between reboots

[Christoph Hellwig]

This patch itself looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

>  static struct configfs_attribute *nvmet_subsys_attrs[] = {
>  	&nvmet_subsys_attr_attr_allow_any_host,
>  	&nvmet_subsys_attr_version,
> +	&nvmet_subsys_attr_attr_serial,

but the new version attribute really needs the attr prefix so that
nvmetcli can pick it up.  And we should also add nvmetcli support
for it.  Can you do the rename before your series to ease backporting
as that should go into 3.12 (just like your serial number fix).