Re: [PATCH 2/2] dt-bindings: mfd: Add bindings for ZII RAVE devices

[Rob Herring]

On Mon, Jul 10, 2017 at 10:04:49AM -0700, Andrey Smirnov wrote:
> Cc: cphealy@xxxxxxxxx
> Cc: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
> Cc: Nikita Yushchenko <nikita.yoush@xxxxxxxxxxxxxxxxxx>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> Cc: Mark Rutland <mark.rutland@xxxxxxx>
> Cc: devicetree@xxxxxxxxxxxxxxx
> Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx>
> ---
>  .../devicetree/bindings/mfd/zii,rave-sp.txt        | 40 ++++++++++++++++++++++
>  1 file changed, 40 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/zii,rave-sp.txt
> 
> diff --git a/Documentation/devicetree/bindings/mfd/zii,rave-sp.txt b/Documentation/devicetree/bindings/mfd/zii,rave-sp.txt
> new file mode 100644
> index 0000000..53192f9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/zii,rave-sp.txt
> @@ -0,0 +1,40 @@
> +Zodiac Inflight Innovations RAVE Supervisory Processor
> +
> +RAVE Supervisory Processor communicates with SoC over UART and is
> +presented to the kernel as a "serdev". It is expected that its

Drop the "and is ..." part. That's a kernel detail and not part of the 
binding. With that,

Acked-by: Rob Herring <robh@xxxxxxxxxx>

> +device-tree node is specified as a child of a node corresponding to
> +UART controller used for communication.
> +
> +Required parent device properties:
> +
> + - compatible: Should be one of:
> +	- "zii,rave-sp-niu"
> +	- "zii,rave-sp-mezz"
> +	- "zii,rave-sp-esb"
> +	- "zii,rave-sp-rdu1"
> +	- "zii,rave-sp-rdu2"
> +
> + - current-speed: Should be set to baud rate SP device is using
> +
> +RAVE SP consists of the following sub-devices:
> +
> +Device				 Description
> +------				 -----------
> +rave-sp-wdt			: Watchdog
> +rave-sp-nvmem			: Interface to onborad EEPROM
> +rave-sp-backlight		: Display backlight
> +rave-sp-hwmon			: Interface to onboard hardware sensors
> +rave-sp-leds			: Interface to onboard LEDs
> +rave-sp-input			: Interface to onboard power button
> +
> +Example of usage:
> +
> +	rdu {
> +		compatible = "zii,rave-sp-rdu2";
> +		current-speed = <1000000>;
> +
> +		watchdog {
> +			compatible = "zii,rave-sp-watchdog";
> +		};
> +	};
> +
> -- 
> 2.9.4
>