Re: [PATCH v2] sctp: don't dereference ptr before leaving _sctp_walk_{params,errors}()

From: David Miller
Date: Fri Jul 14 2017 - 11:58:37 EST


From: Alexander Potapenko <glider@xxxxxxxxxx>
Date: Fri, 14 Jul 2017 12:03:29 +0200

> v2: per comment from David Miller, make sure the whole iterator->length
> fits into the remaining buffer.

Please compile and functionally test your changes:

In file included from ./include/linux/compiler.h:58:0,
from ./include/uapi/linux/stddef.h:1,
from ./include/linux/stddef.h:4,
from ./include/uapi/linux/posix_types.h:4,
from ./include/uapi/linux/types.h:13,
from ./include/linux/types.h:5,
from net/sctp/sm_statefuns.c:48:
net/sctp/sm_statefuns.c: In function ʽsctp_sf_do_reconfʼ:
./include/net/sctp/sctp.h:472:24: error: unknown type name ʽsctp_paramhdr_tʼ
(pos.v + offsetof(sctp_paramhdr_t, length) + sizeof(pos.p->length) <\
^