Re: [PATCH] stm32-dcmi: constify vb2_ops structure

[Gustavo A. R. Silva]

On 07/07/2017 09:33 AM, Hugues FRUCHET wrote:
> Acked-by: Hugues Fruchet <hugues.fruchet@xxxxxx>

Thank you, Hugues.

> On 07/06/2017 10:05 PM, Gustavo A. R. Silva wrote:
> > Check for vb2_ops structures that are only stored in the ops field of a
> > vb2_queue structure. That field is declared const, so vb2_ops structures
> > that have this property can be declared as const also.
> >
> > This issue was detected using Coccinelle and the following semantic patch:
> >
> > @r disable optional_qualifier@
> > identifier i;
> > position p;
> > @@
> > static struct vb2_ops i@p = { ... };
> >
> > @ok@
> > identifier r.i;
> > struct vb2_queue e;
> > position p;
> > @@
> > e.ops = &i@p;
> >
> > @bad@
> > position p != {r.p,ok.p};
> > identifier r.i;
> > struct vb2_ops e;
> > @@
> > e@i@p
> >
> > @depends on !bad disable optional_qualifier@
> > identifier r.i;
> > @@
> > static
> > +const
> > struct vb2_ops i = { ... };
> >
> > Signed-off-by: Gustavo A. R. Silva <garsilva@xxxxxxxxxxxxxx>
> > ---
> >    drivers/media/platform/stm32/stm32-dcmi.c | 2 +-
> >    1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/platform/stm32/stm32-dcmi.c b/drivers/media/platform/stm32/stm32-dcmi.c
> > index 83d32a5..24ef888 100644
> > --- a/drivers/media/platform/stm32/stm32-dcmi.c
> > +++ b/drivers/media/platform/stm32/stm32-dcmi.c
> > @@ -662,7 +662,7 @@ static void dcmi_stop_streaming(struct vb2_queue *vq)
> >    		dcmi->errors_count, dcmi->buffers_count);
> >    }
> >    
> > -static struct vb2_ops dcmi_video_qops = {
> > +static const struct vb2_ops dcmi_video_qops = {
> >    	.queue_setup		= dcmi_queue_setup,
> >    	.buf_init		= dcmi_buf_init,
> >    	.buf_prepare		= dcmi_buf_prepare,

--
Gustavo A. R. Silva