Re: [PATCH 03/14] qcom: mtd: nand: Fixed config error for BCH

[Abhishek Sahu]

On 2017-07-04 01:17, Boris Brezillon wrote:
> On Thu, 29 Jun 2017 11:49:07 +0200
> Marek Vasut <marek.vasut@xxxxxxxxx> wrote:
>
> > On 06/29/2017 09:15 AM, Abhishek Sahu wrote:
> > > The configuration for BCH is not correct in the current
> > > driver so this patch fixed the same.
> >
> > Fix the commit message, I have no idea what this patch does or fixes.
>
> And please add a Fixes tag and Cc stable.

 Sure. I will amend the commit message to make it
 more clear and will include these tags.

> > > Signed-off-by: Abhishek Sahu <absahu@xxxxxxxxxxxxxx>
> > > ---
> > >  drivers/mtd/nand/qcom_nandc.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/mtd/nand/qcom_nandc.c
> b/drivers/mtd/nand/qcom_nandc.c
> > > index 520add9..410ee53 100644
> > > --- a/drivers/mtd/nand/qcom_nandc.c
> > > +++ b/drivers/mtd/nand/qcom_nandc.c
> > > @@ -1919,7 +1919,7 @@ static int qcom_nand_host_setup(struct
> qcom_nand_host *host)
> > >  				| wide_bus << WIDE_FLASH
> > >  				| 1 << DEV0_CFG1_ECC_DISABLE;
> > >
> > > -	host->ecc_bch_cfg = host->bch_enabled << ECC_CFG_ECC_DISABLE
> > > +	host->ecc_bch_cfg = !host->bch_enabled << ECC_CFG_ECC_DISABLE
> > >  				| 0 << ECC_SW_RESET
> > >  				| host->cw_data << ECC_NUM_DATA_BYTES
> > >  				| 1 << ECC_FORCE_CLK_OPEN
> > >

--
Abhishek Sahu