Re: [PATCH 1/2] dt-binding: mfd: Add Maxim/Dallas DS1374 MFD device binding
From: Rob Herring
Date: Mon Jul 17 2017 - 14:51:01 EST
On Thu, Jul 13, 2017 at 12:54:24PM -0700, Moritz Fischer wrote:
> This adds a binding for the Maxim/Dallas DS1374 MFD.
>
> Signed-off-by: Moritz Fischer <mdf@xxxxxxxxxx>
> ---
> Changes from RFC:
> - dallas,ds1374-mode -> dallas,mode
> - Clarified examples
> - dallas,remap-reset property
>
> On second thoughts the solution for the remapping found in the
> discussion did not seem to be a good solution, since the INT
> pin indicating watchdog reset does not necessarily have to be
> connected to an interrupt line on the machine, it could equally
> well be hooked up to a PMIC reset input or similar.
> In that case using the presence of an 'interrupt' phandle is not
> a good choice.
>
> Cheers,
>
> Moritz
>
> ---
> Documentation/devicetree/bindings/mfd/ds1374.txt | 88 ++++++++++++++++++++++
> .../devicetree/bindings/trivial-devices.txt | 1 -
> drivers/rtc/Kconfig | 2 +
This belongs in patch 2. With that dropped,
Acked-by: Rob Herring <robh@xxxxxxxxxx>
> 3 files changed, 90 insertions(+), 1 deletion(-)
> create mode 100644 Documentation/devicetree/bindings/mfd/ds1374.txt