Re: [PATCH 0/2] use correct values for startup time bits for AXP22X/AXP8XX PEKs

From: Lee Jones
Date: Tue Jul 18 2017 - 03:18:56 EST


On Mon, 17 Jul 2017, Quentin Schulz wrote:

> Hi all,
>
> On 17/07/2017 11:53, Quentin Schulz wrote:
> > According to their datasheets, the AXP221, AXP223, AXP288, AXP803,
> > AXP809 and AXP813 PEK have different values for startup time bits from
> > the AXP20X PEK (which are currently used for all the aforementioned PMICs).
> >
> > This patch series adds support for platform_device_id to axp20x-pek driver
> > to support different startup time bits depending on PMIC's variant and set
> > the correct platform_device_id in the mfd.
> >
> > This has been tested on AXP813. To perform the test, modify the value of
> > startup and/or shutdown of the pek in sysfs. Press the button soldered to
> > PEK input of the AXP the amount of time you set in sysfs. The PMIC shuts
> > down the board without needing to unplug any power supply. Press PEK button
> > the amount of time you set in sysfs for startup and the PMIC will start the
> > board. Note that the time bits are obivoulsy hardware reset to their
> > default when you unplug all power supplies from the board.
> >
>
> I forgot to add that it depends on this patch series (particularly the
> third patch (3/6) "mfd: axp20x: Add support for AXP813 PMIC") from
> Chen-Yu:
> https://www.mail-archive.com/linux-kernel@xxxxxxxxxxxxxxx/msg1428284.html

So you are going to re-send?

> > Quentin Schulz (2):
> > Input: axp20x-pek: add support for AXP221 PEK
> > mfd: axp20x: use correct platform device id for many PEK
> >
> > drivers/input/misc/axp20x-pek.c | 62 ++++++++++++++++++++++++++++++++++-------
> > drivers/mfd/axp20x.c | 12 ++++----
> > 2 files changed, 58 insertions(+), 16 deletions(-)
> >
>

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog