Re: [PATCH] serial: 8250: fix error handling in of_platform_serial_probe()
From: Greg Kroah-Hartman
Date: Tue Jul 18 2017 - 03:27:43 EST
On Sat, Jul 01, 2017 at 01:49:29AM +0300, Alexey Khoroshilov wrote:
> clk_disable_unprepare(info->clk) is missed in of_platform_serial_probe(),
> while irq_dispose_mapping(port->irq) is missed in of_platform_serial_setup().
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov <khoroshilov@xxxxxxxxx>
> ---
> drivers/tty/serial/8250/8250_of.c | 20 +++++++++++++-------
> 1 file changed, 13 insertions(+), 7 deletions(-)
I've had to drop this from my tree due to the obvious build warning it
adds to the system. Always test-build your patches before sending them
out, it makes maintainers grumpy when you do not do that :(
greg k-h