Re: [RFC PATCH v12 4/4] LRNG - enable compile

[Arnd Bergmann]

On Tue, Jul 18, 2017 at 9:59 AM, Stephan MÃller <smueller@xxxxxxxxxx> wrote:
> Add LRNG compilation support.
>
> diff --git a/drivers/char/Makefile b/drivers/char/Makefile
> index 53e3372..87e06ec 100644
> --- a/drivers/char/Makefile
> +++ b/drivers/char/Makefile
> @@ -2,7 +2,15 @@
>  # Makefile for the kernel character device drivers.
>  #
>
> -obj-y                          += mem.o random.o
> +obj-y                          += mem.o
> +
> +ifeq ($(CONFIG_LRNG),y)
> +  obj-$(CONFIG_LRNG)           += lrng.o
> +  lrng-y                       += lrng_base.o lrng_chacha20.o
> +else
> +  obj-y                                += random.o
> +endif

I think you can write the same in a more readable way without the
intermediate object:

ifdef CONFIG_LRNG
  obj-y                       += lrng_base.o lrng_chacha20.o
else
  obj-y                       += random.o
endif

      Arnd