Re: [PATCH] perf probe: Fix build failure for get_target_map()

From: Arnaldo Carvalho de Melo
Date: Tue Jul 18 2017 - 11:45:47 EST


Em Tue, Jul 18, 2017 at 07:19:45PM +1000, Michael Ellerman escreveu:
> Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> writes:
>
> > Em Mon, Jul 17, 2017 at 04:02:22PM +0530, Ravi Bangoria escreveu:
> >> Commit 801bc8193463 ("perf probe: Allow placing uprobes in
> >> alternate namespaces.") is causing a build failure on powerpc:
> >>
> >> error: incompatible type for argument 2 of 'get_target_map'
> >> map = get_target_map(pev->target, pev->uprobes);
> >> ^~~
> >>
> >> Fix it by changing parameters of get_target_map().
> >
> > Thanks, since this hasn't made it to Ingo I'll fold this into the patch
> > where the problem was introduced, adding credits to you, leaving a Link
> > to this message, so that we don't lose bisection in this area on
> > powerpc.
>
> Thanks.
>
> I just bisected to this commit too - should have checked the list first! :)

:-)

I just re-ammended this cset to cover the !HAVE_DWARF_SUPPORT build as
well, just re-force-pushed acme/perf/core with this fix.

- Arnaldo