Re: [PATCH 1/3] ACPI / blacklist: add acpi_match_oemlist() interface

From: Borislav Petkov
Date: Tue Jul 18 2017 - 12:44:06 EST


On Tue, Jul 18, 2017 at 03:48:54PM +0000, Kani, Toshimitsu wrote:
> This patch defines 'struct acpi_oemlist' in "include/linux/acpi.h" as a

I see that.

> common structure, and replaces this specific 'struct acpi_blacklist'.

And what makes acpi_oemlist "common" and acpi_blacklist "specific"?

So let me save you some time - "oemlist" is more specific than
"blacklist" and I can imagine a blacklist item not always being
oem-specific.

What I'm hinting at is, don't change that name. acpi_blacklist is just
fine.

> Agreed. Will change to a shorter name like below.
>
> enum acpi_oemlist_pred predicate;

enum acpi_predicate pred;

is even better.

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.
--