Re: [PATCH 2/2] MIPS: ralink: mt7620: Add missing header

[Ralf Baechle]

On Tue, Jul 18, 2017 at 02:25:46PM +0100, Harvey Hunt wrote:

> Fix a build error caused by not including <linux/bug.h>.
> 
> The following compilation errors are caused by the missing header:
> 
> arch/mips/ralink/mt7620.c: In function âmt7620_get_cpu_pll_rateâ:
> arch/mips/ralink/mt7620.c:431:2: error: implicit declaration of function âWARN_ONâ [-Werror=implicit-function-declaration]
>   WARN_ON(div >= ARRAY_SIZE(mt7620_clk_divider));
>   ^
> arch/mips/ralink/mt7620.c: In function âmt7620_get_sys_rateâ:
> arch/mips/ralink/mt7620.c:500:2: error: implicit declaration of function âWARNâ [-Werror=implicit-function-declaration]
>   if (WARN(!div, "invalid divider for OCP ratio %u", ocp_ratio))
>   ^
> arch/mips/ralink/mt7620.c: In function âmt7620_dram_initâ:
> arch/mips/ralink/mt7620.c:619:3: error: implicit declaration of function âBUGâ [-Werror=implicit-function-declaration]
>    BUG();
>    ^
> cc1: some warnings being treated as errors
> scripts/Makefile.build:302: recipe for target 'arch/mips/ralink/mt7620.o' failed
> 
> Signed-off-by: Harvey Hunt <harvey.hunt@xxxxxxxxxx>
> Cc: John Crispin <john@xxxxxxxxxxx>
> Cc: linux-mips@xxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx

Same comment as for the previous patch - looks sensible, so applied.  But
I'm wondering why I don't see this in test builds.

  Ralf