Re: [PATCH 1/2] MIPS: ralink: Fix build error due to missing header

[Harvey Hunt]

Hi Ralf,

On 18/07/17 23:01, Ralf Baechle wrote:
> On Tue, Jul 18, 2017 at 02:25:45PM +0100, Harvey Hunt wrote:
>
> > Previously, <linux/module.h> was included before ralink_regs.h in all
> > ralink files - leading to <linux/io.h> being implicitly included.
> >
> > After commit 26dd3e4ff9ac ("MIPS: Audit and remove any unnecessary
> > uses of module.h") removed the inclusion of module.h from multiple
> > places, some ralink platforms failed to build with the following error:
> >
> > In file included from arch/mips/ralink/mt7620.c:17:0:
> > ./arch/mips/include/asm/mach-ralink/ralink_regs.h: In function ârt_sysc_w32â:
> > ./arch/mips/include/asm/mach-ralink/ralink_regs.h:38:2: error: implicit declaration of function â__raw_writelâ [-Werror=implicit-function-declaration]
> >    __raw_writel(val, rt_sysc_membase + reg);
> >    ^
> > ./arch/mips/include/asm/mach-ralink/ralink_regs.h: In function ârt_sysc_r32â:
> > ./arch/mips/include/asm/mach-ralink/ralink_regs.h:43:2: error: implicit declaration of function â__raw_readlâ [-Werror=implicit-function-declaration]
> >    return __raw_readl(rt_sysc_membase + reg);
> >
> > Fix this by including <linux/io.h>.
>
> Looks sensible, applied.  But I'm wondering why I don't see this in my
> test builds.

Thanks for merging them. There isn't currently a defconfig for this 
platform, but I am working on adding one.

>    Ralf

Thanks,

Harvey