Re: [PATCH 071/102] remoteproc/keystone: explicitly request exclusive reset control

From: Suman Anna
Date: Wed Jul 19 2017 - 12:59:24 EST


On 07/19/2017 10:26 AM, Philipp Zabel wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Ohad Ben-Cohen <ohad@xxxxxxxxxx>
> Cc: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> Cc: linux-remoteproc@xxxxxxxxxxxxxxx
> Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>

Acked-by: Suman Anna <s-anna@xxxxxx>

> ---
> drivers/remoteproc/keystone_remoteproc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/keystone_remoteproc.c b/drivers/remoteproc/keystone_remoteproc.c
> index 5f776bfd674a0..920fef072b364 100644
> --- a/drivers/remoteproc/keystone_remoteproc.c
> +++ b/drivers/remoteproc/keystone_remoteproc.c
> @@ -410,7 +410,7 @@ static int keystone_rproc_probe(struct platform_device *pdev)
> if (ret)
> goto free_rproc;
>
> - ksproc->reset = devm_reset_control_get(dev, NULL);
> + ksproc->reset = devm_reset_control_get_exclusive(dev, NULL);
> if (IS_ERR(ksproc->reset)) {
> ret = PTR_ERR(ksproc->reset);
> goto free_rproc;
>