Re: [PATCH v2 3/4] PM: Print wall time at suspend & hibernate entry and exit

[Mark Salyzyn]

On 07/19/2017 01:40 PM, Rafael J. Wysocki wrote:
> On Wed, Jul 19, 2017 at 9:45 PM, Mark Salyzyn <salyzyn@xxxxxxxxxxx> wrote:
> > Permits power state and battery life diagnosis.
> >
> > Since one is not guaranteed to have a persistent hardware clock to
> > report Suspended for in milliseconds, we report at a higher level
> > at just the entry and exit points for suspend and hibernate.
> >
> > Feature activated by CONFIG_RTC_SHOW_TIME_*
> >
> > Signed-off-by: Mark Salyzyn <salyzyn@xxxxxxxxxxx>
> >
> > v2:
> > - merge suspend and hibernate into a single patch
> So now I guess you realize that this conflicts with
> https://patchwork.kernel.org/patch/9850217/ and it actually would make
> sense for it to go on top of that?
>
> Thanks,
> Rafael

I see. It would make sense to merge the concepts a bit since the prints 
are at the same locations.

Optimization idea: rtc_show_time() in my patch series should be able to 
support varargs, never be _disabled_ (CONFIG_RTC_SHOW_TIME_NONE idea is 
dropped) and the function would be a drop-in replacement for pr_info, 
but add the specified timestamp before the newline. Change it's name to 
pr_info_show_time() instead to reflect this adjustment.

I would also prefer that the base messages in patch/980217 be "PM: 
suspend entry" and "PM: suspend exit", only because I believe 1.6billion 
Linux devices would not need to be retooled, and besides these messages 
are shorter/sweeter.

Anyone disagree with some more over-engineering (pr_info_show_time() and 
varargs)

-- Mark