Re: [PATCH v4 01/14] spi: qup: Enable chip select support

[Varadarajan Narayanan]

Brown,

On Mon, Jul 17, 2017 at 05:01:51PM +0100, Mark Brown wrote:
> On Tue, Jun 27, 2017 at 03:15:18PM +0530, Varadarajan Narayanan wrote:
>
> > the chip select support was removed earlier in commit
> > 4a8573abe965115bc5b064401fd669b74e985258. Since the chip
>
> Please include human readable descriptions of things like commits and
> issues being discussed in e-mail in your mails, this makes them much
> easier for humans to read especially when they have no internet access.
> I do frequently catch up on my mail on flights or while otherwise
> travelling so this is even more pressing for me than just being about
> making things a bit easier to read.

Sorry. The commit being referred to is (https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4a8573abe965115bc5b064401fd669b74e985258)

	commit 4a8573abe965115bc5b064401fd669b74e985258
	Author: Andy Gross <agross@xxxxxxxxxxxxxx>
	Date:   Thu Jun 12 14:34:10 2014 -0500

	spi: qup: Remove chip select function

	This patch removes the chip select function.  Chip select should instead be
	supported using GPIOs, defining the DT entry "cs-gpios", and letting the SPI
	core assert/deassert the chip select as it sees fit.

	The chip select control inside the controller is buggy.  It is supposed to
	automatically assert the chip select based on the activity in the controller,
	but it is buggy and doesn't work at all.  So instead we elect to use GPIOs.

	Signed-off-by: Andy Gross <agross@xxxxxxxxxxxxxx>
	Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>

Will update the commit log and repost the patches.

Thanks
Varada

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation