Re: [PATCH v1 4/7] drm/stm: ltdc: Constify funcs structures

[Benjamin Gaignard]

2017-07-18 12:20 GMT+02:00 Philippe CORNU <philippe.cornu@xxxxxx>:
> Constify drm funcs structures.
>
> Signed-off-by: Philippe CORNU <philippe.cornu@xxxxxx>

Reviewed-by: Benjamin Gaignard <benjamin.gaignard@xxxxxxxxxx>

> ---
>  drivers/gpu/drm/stm/ltdc.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index 628825b..92e58ba 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -511,7 +511,7 @@ static void ltdc_crtc_atomic_flush(struct drm_crtc *crtc,
>         }
>  }
>
> -static struct drm_crtc_helper_funcs ltdc_crtc_helper_funcs = {
> +static const struct drm_crtc_helper_funcs ltdc_crtc_helper_funcs = {
>         .load_lut = ltdc_crtc_load_lut,
>         .mode_set_nofb = ltdc_crtc_mode_set_nofb,
>         .atomic_flush = ltdc_crtc_atomic_flush,
> @@ -537,7 +537,7 @@ void ltdc_crtc_disable_vblank(struct drm_device *ddev, unsigned int pipe)
>         reg_clear(ldev->regs, LTDC_IER, IER_LIE);
>  }
>
> -static struct drm_crtc_funcs ltdc_crtc_funcs = {
> +static const struct drm_crtc_funcs ltdc_crtc_funcs = {
>         .destroy = drm_crtc_cleanup,
>         .set_config = drm_atomic_helper_set_config,
>         .page_flip = drm_atomic_helper_page_flip,
> @@ -693,7 +693,7 @@ static void ltdc_plane_atomic_disable(struct drm_plane *plane,
>                          oldstate->crtc->base.id, plane->base.id);
>  }
>
> -static struct drm_plane_funcs ltdc_plane_funcs = {
> +static const struct drm_plane_funcs ltdc_plane_funcs = {
>         .update_plane = drm_atomic_helper_update_plane,
>         .disable_plane = drm_atomic_helper_disable_plane,
>         .destroy = drm_plane_cleanup,
> --
> 1.9.1
>



-- 
Benjamin Gaignard

Graphic Study Group

Linaro.org â Open source software for ARM SoCs

Follow Linaro: Facebook | Twitter | Blog