Re: [PATCH v3 15/23] doc: media/v4l-drivers: Qualcomm Camera Subsystem - PIX Interface

[Sakari Ailus]

On Mon, Jul 17, 2017 at 01:33:41PM +0300, Todor Tomov wrote:
> Update Qualcomm Camera Subsystem driver document for the PIX interface
> and format conversion support.
> 
> Signed-off-by: Todor Tomov <todor.tomov@xxxxxxxxxx>
> ---
>  Documentation/media/v4l-drivers/qcom_camss.rst | 41 +++++++++++++++++++-------
>  1 file changed, 31 insertions(+), 10 deletions(-)
> 
> diff --git a/Documentation/media/v4l-drivers/qcom_camss.rst b/Documentation/media/v4l-drivers/qcom_camss.rst
> index 4707ea7..4df5655 100644
> --- a/Documentation/media/v4l-drivers/qcom_camss.rst
> +++ b/Documentation/media/v4l-drivers/qcom_camss.rst
> @@ -45,12 +45,31 @@ Supported functionality
>  
>  The current version of the driver supports:
>  
> -- input from camera sensor via CSIPHY;
> -- generation of test input data by the TG in CSID;
> -- raw dump of the input data to memory. RDI interface of VFE is supported.
> -  PIX interface (ISP processing, statistics engines, resize/crop, format
> -  conversion) is not supported in the current version;
> -- concurrent and independent usage of two data inputs - could be camera sensors
> +- Input from camera sensor via CSIPHY;
> +- Generation of test input data by the TG in CSID;
> +- RDI interface of VFE - raw dump of the input data to memory.
> +
> +  Supported formats:
> +
> +  - YUYV/UYVY/YVYU/VYUY (packed YUV 4:2:2);
> +  - MIPI RAW8 (8bit Bayer RAW);
> +  - MIPI RAW10 (10bit packed Bayer RAW);
> +  - MIPI RAW12 (12bit packed Bayer RAW).
> +
> +- PIX interface of VFE
> +
> +  - Format conversion of the input data.
> +
> +    Supported input formats:
> +
> +    - YUYV/UYVY/YVYU/VYUY (packed YUV 4:2:2).
> +
> +    Supported output formats:
> +
> +    - NV12/NV21 (two plane YUV 4:2:0);
> +    - NV16/NV61 (two plane YUV 4:2:2).

Could you add V4L2 format names to these?

> +
> +- Concurrent and independent usage of two data inputs - could be camera sensors
>    and/or TG.
>  
>  
> @@ -65,15 +84,15 @@ interface, the driver is split into V4L2 sub-devices as follows:
>  - 2 CSID sub-devices - each CSID is represented by a single sub-device;
>  - 2 ISPIF sub-devices - ISPIF is represented by a number of sub-devices equal
>    to the number of CSID sub-devices;
> -- 3 VFE sub-devices - VFE is represented by a number of sub-devices equal to
> -  the number of RDI input interfaces.
> +- 4 VFE sub-devices - VFE is represented by a number of sub-devices equal to
> +  the number of the input interfaces (3 RDI and 1 PIX).
>  
>  The considerations to split the driver in this particular way are as follows:
>  
>  - representing CSIPHY and CSID modules by a separate sub-device for each module
>    allows to model the hardware links between these modules;
> -- representing VFE by a separate sub-devices for each RDI input interface allows
> -  to use the three RDI interfaces concurently and independently as this is
> +- representing VFE by a separate sub-devices for each input interface allows
> +  to use the input interfaces concurently and independently as this is
>    supported by the hardware;
>  - representing ISPIF by a number of sub-devices equal to the number of CSID
>    sub-devices allows to create linear media controller pipelines when using two
> @@ -99,6 +118,8 @@ nodes) is as follows:
>  - msm_vfe0_video1
>  - msm_vfe0_rdi2
>  - msm_vfe0_video2
> +- msm_vfe0_pix
> +- msm_vfe0_video3
>  
>  
>  Implementation
> -- 
> 2.7.4
> 

-- 
Sakari Ailus
e-mail: sakari.ailus@xxxxxx	XMPP: sailus@xxxxxxxxxxxxxx