Re: [PATCH 2/3] usb: xhci: Add DbC support in xHCI driver

From: Felipe Balbi
Date: Fri Jul 21 2017 - 06:31:59 EST



Hi,

Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx> writes:
> +static void xhci_dbc_stop(struct xhci_hcd *xhci)
> +{
> + struct xhci_dbc *dbc = xhci->dbc;
> +
> + WARN_ON(!dbc);
> +
> + cancel_delayed_work_sync(&dbc->event_work);
> +
> + if (dbc->gs_port_num != GSPORT_INVAL) {
> + gserial_disconnect(&dbc->gs_port);
> + gserial_free_line(dbc->gs_port_num);

why are you tying host stack to the gadget framework?

With this, you're forcing every single PC in the world to compile the
gadget framework, that's a bit much don't you think?

--
balbi

Attachment: signature.asc
Description: PGP signature