Re: [PATCH v6 RESEND] x86/boot/KASLR: Restrict kernel to be randomized in mirror regions

[Baoquan He]

On 07/21/17 at 07:37pm, Ingo Molnar wrote:
> 
> * Baoquan He <bhe@xxxxxxxxxx> wrote:
> 
> > > > +static inline bool process_efi_entries(unsigned long minimum,
> > > > +				       unsigned long image_size)
> > > 
> > > ugly linebreak again ...
> > 
> > The whole line is more than 80. I break the line and use tab and space
> > to make it align with above 'unsigned long minimum'. Don't know why it
> > becomes messy in patch. Will check and try again.
> 
> Then make the linebreak less ugly, or ignore the checkpatch warning!
> 
> This commonly used pattern:
> 
>   static inline bool
>   process_efi_entries(unsigned long minimum, unsigned long image_size)
> 
> looks a lot better than the function parameter list broken in the middle.

Got it, will use this one. Thanks a lot!