Re: [PATCH 038/102] mmc: dw_mmc: explicitly request exclusive reset control

[Shawn Lin]

On 2017/7/19 23:25, Philipp Zabel wrote:
> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
>
> No functional changes.
>
> Cc: Jaehoon Chung <jh80.chung@xxxxxxxxxxx>
> Cc: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
> Cc: linux-mmc@xxxxxxxxxxxxxxx
> Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>

Reviewed-by: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx>

> ---
>  drivers/mmc/host/dw_mmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index a9dfb26972f21..7c1e2dbc76776 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -2950,7 +2950,7 @@ static struct dw_mci_board *dw_mci_parse_dt(struct dw_mci *host)
>  		return ERR_PTR(-ENOMEM);
>
>  	/* find reset controller when exist */
> -	pdata->rstc = devm_reset_control_get_optional(dev, "reset");
> +	pdata->rstc = devm_reset_control_get_optional_exclusive(dev, "reset");
>  	if (IS_ERR(pdata->rstc)) {
>  		if (PTR_ERR(pdata->rstc) == -EPROBE_DEFER)
>  			return ERR_PTR(-EPROBE_DEFER);


--
Best Regards
Shawn Lin