Re: [PATCH v6 1/1] acpi: apei: Enable APEI multiple GHES source to share a single external IRQ

[Rafael J. Wysocki]

On Saturday, July 22, 2017 07:59:54 AM Borislav Petkov wrote:
> On Fri, Jul 21, 2017 at 11:24:37AM -0700, Loc Ho wrote:
> > X-Gene platforms describe multiple GHES error sources with the same hardware
> > error notification type (external interrupt) and interrupt number.
> > Change the GHES interrupt request to support sharing the same IRQ.
> > 
> > Co-authored-by: Tuan Phan <tphan@xxxxxxx>
> > Signed-off-by: Loc Ho <lho@xxxxxxx>
> > ---
> >  drivers/acpi/apei/ghes.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> > index d661d45..eed09fc 100644
> > --- a/drivers/acpi/apei/ghes.c
> > +++ b/drivers/acpi/apei/ghes.c
> > @@ -1157,7 +1157,8 @@ static int ghes_probe(struct platform_device *ghes_dev)
> >  			       generic->header.source_id);
> >  			goto err_edac_unreg;
> >  		}
> > -		rc = request_irq(ghes->irq, ghes_irq_func, 0, "GHES IRQ", ghes);
> > +		rc = request_irq(ghes->irq, ghes_irq_func, IRQF_SHARED,
> > +				 "GHES IRQ", ghes);
> >  		if (rc) {
> >  			pr_err(GHES_PFX "Failed to register IRQ for generic hardware error source: %d\n",
> >  			       generic->header.source_id);
> 
> Acked-by: Borislav Petkov <bp@xxxxxxx>

OK

Should I apply this or will Tony do that?