Re: [PATCH] HID: rmi: Make sure the HID device is opened on resume

[Andy Shevchenko]

On Sun, Jul 23, 2017 at 4:15 AM, Lyude <lyude@xxxxxxxxxx> wrote:

> So, call hid_hw_open() in rmi_post_resume() so we make sure that the
> device is alive before we try talking to it.
>
> This fixes RMI device suspend/resume over HID.

> -       int ret;
> +       int ret = 0;

What's the point?

>
>         if (!(data->device_flags & RMI_DEVICE))
>                 return 0;
>
> -       ret = rmi_reset_attn_mode(hdev);
> +       /* Make sure the HID device is ready to receive events */
> +       ret = hid_hw_open(hdev);
>         if (ret)
>                 return ret;

-- 
With Best Regards,
Andy Shevchenko