Re: [PATCH v2 1/2] x86/amd: Refactor topology extension related code

From: kbuild test robot
Date: Sun Jul 23 2017 - 15:26:32 EST

Hi Suravee,

[auto build test ERROR on tip/x86/core]
[also build test ERROR on v4.13-rc1 next-20170721]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Suravee-Suthikulpanit/x86-amd-Refactor-topology-extension-related-code/20170724-024344
config: x86_64-randconfig-x007-201730 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64

All errors (new ones prefixed by >>):

arch/x86/kernel/cpu/amd.c: In function '__get_topoext':
>> arch/x86/kernel/cpu/amd.c:309:19: error: lvalue required as left operand of assignment
smp_num_siblings = ((ebx >> 8) & 0xff) + 1;
^
At top level:
arch/x86/kernel/cpu/amd.c:302:13: warning: '__get_topoext' defined but not used [-Wunused-function]
static void __get_topoext(struct cpuinfo_x86 *c)
^~~~~~~~~~~~~

vim +309 arch/x86/kernel/cpu/amd.c

^1da177e arch/i386/kernel/cpu/amd.c Linus Torvalds 2005-04-16 298
11fdd252 arch/x86/kernel/cpu/amd.c Yinghai Lu 2008-09-07 299 /*
1c2d1f62 arch/x86/kernel/cpu/amd.c Suravee Suthikulpanit 2017-07-21 300 * Get topology information via X86_FEATURE_TOPOEXT
4a376ec3 arch/x86/kernel/cpu/amd.c Andreas Herrmann 2009-09-03 301 */
1c2d1f62 arch/x86/kernel/cpu/amd.c Suravee Suthikulpanit 2017-07-21 302 static void __get_topoext(struct cpuinfo_x86 *c)
4a376ec3 arch/x86/kernel/cpu/amd.c Andreas Herrmann 2009-09-03 303 {
79a8b9aa arch/x86/kernel/cpu/amd.c Borislav Petkov 2017-02-05 304 u32 eax, ebx, ecx, edx;
1c2d1f62 arch/x86/kernel/cpu/amd.c Suravee Suthikulpanit 2017-07-21 305 int cpu = smp_processor_id();
6057b4d3 arch/x86/kernel/cpu/amd.c Andreas Herrmann 2010-09-30 306
79a8b9aa arch/x86/kernel/cpu/amd.c Borislav Petkov 2017-02-05 307 cpuid(0x8000001e, &eax, &ebx, &ecx, &edx);
79a8b9aa arch/x86/kernel/cpu/amd.c Borislav Petkov 2017-02-05 308
79a8b9aa arch/x86/kernel/cpu/amd.c Borislav Petkov 2017-02-05 @309 smp_num_siblings = ((ebx >> 8) & 0xff) + 1;
79a8b9aa arch/x86/kernel/cpu/amd.c Borislav Petkov 2017-02-05 310
79a8b9aa arch/x86/kernel/cpu/amd.c Borislav Petkov 2017-02-05 311 if (c->x86 == 0x15)
79a8b9aa arch/x86/kernel/cpu/amd.c Borislav Petkov 2017-02-05 312 c->cu_id = ebx & 0xff;
b6a50cdd arch/x86/kernel/cpu/amd.c Yazen Ghannam 2016-11-08 313
08b25963 arch/x86/kernel/cpu/amd.c Yazen Ghannam 2017-02-05 314 if (c->x86 >= 0x17) {
08b25963 arch/x86/kernel/cpu/amd.c Yazen Ghannam 2017-02-05 315 c->cpu_core_id = ebx & 0xff;
08b25963 arch/x86/kernel/cpu/amd.c Yazen Ghannam 2017-02-05 316
08b25963 arch/x86/kernel/cpu/amd.c Yazen Ghannam 2017-02-05 317 if (smp_num_siblings > 1)
08b25963 arch/x86/kernel/cpu/amd.c Yazen Ghannam 2017-02-05 318 c->x86_max_cores /= smp_num_siblings;
08b25963 arch/x86/kernel/cpu/amd.c Yazen Ghannam 2017-02-05 319 }
08b25963 arch/x86/kernel/cpu/amd.c Yazen Ghannam 2017-02-05 320
b6a50cdd arch/x86/kernel/cpu/amd.c Yazen Ghannam 2016-11-08 321 /*
b6a50cdd arch/x86/kernel/cpu/amd.c Yazen Ghannam 2016-11-08 322 * We may have multiple LLCs if L3 caches exist, so check if we
b6a50cdd arch/x86/kernel/cpu/amd.c Yazen Ghannam 2016-11-08 323 * have an L3 cache by looking at the L3 cache CPUID leaf.
b6a50cdd arch/x86/kernel/cpu/amd.c Yazen Ghannam 2016-11-08 324 */
b6a50cdd arch/x86/kernel/cpu/amd.c Yazen Ghannam 2016-11-08 325 if (cpuid_edx(0x80000006)) {
b6a50cdd arch/x86/kernel/cpu/amd.c Yazen Ghannam 2016-11-08 326 if (c->x86 == 0x17) {
b6a50cdd arch/x86/kernel/cpu/amd.c Yazen Ghannam 2016-11-08 327 /*
b6a50cdd arch/x86/kernel/cpu/amd.c Yazen Ghannam 2016-11-08 328 * LLC is at the core complex level.
b6a50cdd arch/x86/kernel/cpu/amd.c Yazen Ghannam 2016-11-08 329 * Core complex id is ApicId[3].
b6a50cdd arch/x86/kernel/cpu/amd.c Yazen Ghannam 2016-11-08 330 */
b6a50cdd arch/x86/kernel/cpu/amd.c Yazen Ghannam 2016-11-08 331 per_cpu(cpu_llc_id, cpu) = c->apicid >> 3;
b6a50cdd arch/x86/kernel/cpu/amd.c Yazen Ghannam 2016-11-08 332 } else {
b6a50cdd arch/x86/kernel/cpu/amd.c Yazen Ghannam 2016-11-08 333 /* LLC is at the node level. */
1c2d1f62 arch/x86/kernel/cpu/amd.c Suravee Suthikulpanit 2017-07-21 334 u8 node_id = ecx & 0xff;
1c2d1f62 arch/x86/kernel/cpu/amd.c Suravee Suthikulpanit 2017-07-21 335
b6a50cdd arch/x86/kernel/cpu/amd.c Yazen Ghannam 2016-11-08 336 per_cpu(cpu_llc_id, cpu) = node_id;
b6a50cdd arch/x86/kernel/cpu/amd.c Yazen Ghannam 2016-11-08 337 }
b6a50cdd arch/x86/kernel/cpu/amd.c Yazen Ghannam 2016-11-08 338 }
1c2d1f62 arch/x86/kernel/cpu/amd.c Suravee Suthikulpanit 2017-07-21 339 }
1c2d1f62 arch/x86/kernel/cpu/amd.c Suravee Suthikulpanit 2017-07-21 340

:::::: The code at line 309 was first introduced by commit
:::::: 79a8b9aa388b0620cc1d525d7c0f0d9a8a85e08e x86/CPU/AMD: Bring back Compute Unit ID

:::::: TO: Borislav Petkov <bp@xxxxxxx>
:::::: CC: Ingo Molnar <mingo@xxxxxxxxxx>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: application/gzip