Re: [PATCH v3 2/8] MIPS: ranchu: Add Goldfish RTC driver

From: kbuild test robot
Date: Sun Jul 23 2017 - 19:52:52 EST


Hi Miodrag,

[auto build test WARNING on linus/master]
[also build test WARNING on v4.13-rc1 next-20170721]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Aleksandar-Markovic/MIPS-Add-virtual-Ranchu-board-as-a-generic-based-board/20170724-062318
config: blackfin-allyesconfig (attached as .config)
compiler: bfin-uclinux-gcc (GCC) 6.2.0
reproduce:
wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=blackfin

All warnings (new ones prefixed by >>):

drivers/rtc/rtc-goldfish.c: In function 'goldfish_rtc_set_alarm':
>> drivers/rtc/rtc-goldfish.c:86:21: warning: right shift count >= width of type [-Wshift-count-overflow]
writel((rtc_alarm >> 32), base + TIMER_ALARM_HIGH);
^~
drivers/rtc/rtc-goldfish.c: In function 'goldfish_rtc_set_time':
drivers/rtc/rtc-goldfish.c:167:15: warning: right shift count >= width of type [-Wshift-count-overflow]
writel((now >> 32), base + TIMER_TIME_HIGH);
^~

vim +86 drivers/rtc/rtc-goldfish.c

67
68 static int goldfish_rtc_set_alarm(struct device *dev,
69 struct rtc_wkalrm *alrm)
70 {
71 struct goldfish_rtc *rtcdrv;
72 unsigned long rtc_alarm;
73 u64 rtc_status_reg;
74 void __iomem *base;
75 int ret = 0;
76
77 rtcdrv = dev_get_drvdata(dev);
78 base = rtcdrv->base;
79
80 if (alrm->enabled) {
81 ret = rtc_tm_to_time(&(alrm->time), &rtc_alarm);
82 if (ret != 0)
83 return ret;
84
85 rtc_alarm *= NSEC_PER_SEC;
> 86 writel((rtc_alarm >> 32), base + TIMER_ALARM_HIGH);
87 writel(rtc_alarm, base + TIMER_ALARM_LOW);
88 } else {
89 /*
90 * if this function was called with enabled=0
91 * then it could mean that the application is
92 * trying to cancel an ongoing alarm
93 */
94 rtc_status_reg = readl(base + TIMER_ALARM_STATUS);
95 if (rtc_status_reg)
96 writel(1, base + TIMER_CLEAR_ALARM);
97 }
98
99 return ret;
100 }
101

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: application/gzip