Re: [linux-sunxi] [PATCH v3 2/5] iio: adc: sun4i-gpadc-iio: rename A23/A33-specified registers to contain A23

[icenowy]

å 2017-07-24 14:02ïChen-Yu Tsai åéï
> On Sun, Jul 23, 2017 at 10:13 PM, Icenowy Zheng <icenowy@xxxxxxx> 
> wrote:
> > As the H3 SoC, which is also in sun8i line, has totally different
> > register map for the thermal sensor (a cut down version of GPADC), we
> > should rename A23/A33-specified registers to contain A23, in order to
> > prevent obfuscation with H3 registers. Currently these registers are
> > only prefixed "SUN8I", not "SUN8I_A23".
> >
> > Add "_A23" after "SUN8I" on the register names.
>
> Nit: the compatible string as well as the initial driver targets the 
> A33.
> Naming the registers as such would be more consistent.

But the registers are the same between A23 and A33.

In fact the only difference between A23 and A33 is the formula's 
factors.

> Otherwise,
>
> Reviewed-by: Chen-Yu Tsai <wens@xxxxxxxx>