Re: [PATCH 3/3] ghes_edac: add platform check to enable ghes_edac

From: Mauro Carvalho Chehab
Date: Mon Jul 24 2017 - 12:04:31 EST


Em Mon, 24 Jul 2017 17:37:16 +0200
Borislav Petkov <bp@xxxxxxxxx> escreveu:

> > Customers do not see error counts.ÂÂI do not think it's bogus.

> > I am just trying to enable OS error reporting with ghes_edac.
>
> I know, you don't have to state the obvious constantly.

The problem I see is that, currently, on users that have EDAC
already enabled, the users gets the errors directly from the
hardware.

If the Kernel force those users to use ghes_edac by default,
they they won't see the error counts anymore, but, instead,
hardware reports that the memories need to be replaced.

Well, if such users are handling thresholds themselves, they
won't see those errors anymore, as the errors will be masked.

That's a regression.

So, the right solution would be to keep hardware first, but
providing a modprobe parameter to let them switch to software
first.

Thanks,
Mauro