Re: [PATCH 3/9] firmware: arm_scmi: add basic driver infrastructure for SCMI
From: Sudeep Holla
Date: Mon Jul 24 2017 - 12:21:53 EST
On 24/07/17 16:41, Jassi Brar wrote:
> On Mon, Jul 24, 2017 at 3:20 PM, Sudeep Holla <sudeep.holla@xxxxxxx> wrote:
>>
>>
>> On 08/07/17 06:32, Jassi Brar wrote:
>>> Hi Roy, Matt, Nishant, Harb Abdulhamid, Loc,
>>>
>>> I have a gut feeling you guys were part of the SCMI spec committee. If
>>> so, could you please chime in?
>>>
>>
>> I take complete silence as no objection.
>>
> I take it as no self respecting developer/architect would stand by
> your FUBAR implementation of SCMI.
>
Wow really ? This is exactly how ACPI PCC works today IIUC.
> SCMI calls
> mbox_send_message(struct mbox_chan *chan, struct scmi_xfer *xfer);
>
> whereas the API expects
> mbox_send_message(struct mbox_chan *chan, struct controller_specific *xfer);
>
That's not hard to change but you seem to have combined my ARM MHU
changes into this which is totally wrong and now I say also stupid after
mentioning the same thing so many times. Consider them independently and
try to understand.
> As the maintainer I have tried to explain it to you in a dozen ways.
> If you still can't see how it's broken, you can't be helped.
>
Sorry but you wanted driver to explain initially. I posted them. But you
haven't answer my specific questions yet.
--
Regards,
Sudeep