Re: [PATCH v2] mm: Drop useless local parameters of __register_one_node()

From: Dou Liyang
Date: Tue Jul 25 2017 - 07:15:54 EST


Hi Michael,

At 07/25/2017 05:09 PM, Michael Ellerman wrote:
Dou Liyang <douly.fnst@xxxxxxxxxxxxxx> writes:

... initializes local parameters "p_node" & "parent" for
register_node().

But, register_node() does not use them.

Remove the related code of "parent" node, cleanup __register_one_node()
and register_node().

Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Cc: David Rientjes <rientjes@xxxxxxxxxx>
Cc: Michal Hocko <mhocko@xxxxxxxxxx>
Cc: isimatu.yasuaki@xxxxxxxxxxxxxx
Signed-off-by: Dou Liyang <douly.fnst@xxxxxxxxxxxxxx>
Acked-by: David Rientjes <rientjes@xxxxxxxxxx>
---
V1 --> V2:
Rebase it on
git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git akpm

drivers/base/node.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)

That appears to be the last user of parent_node().

Oops, yes, it is the last one.


Can we start removing it from the topology.h headers for each arch?


Yes, I think so.

Thanks,
dou.

cheers