Re: [PATCH] [RESEND] gpu: ipu-v3: add DRM dependency
From: Arnd Bergmann
Date: Tue Jul 25 2017 - 07:35:21 EST
On Tue, Jul 25, 2017 at 10:03 AM, Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> wrote:
> On Tue, 2017-07-25 at 09:33 +0200, Arnd Bergmann wrote:
>> On Mon, Jul 24, 2017 at 10:05 AM, Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> wrote:
>> > On Fri, 2017-07-21 at 22:56 +0200, Arnd Bergmann wrote:
>> If you only need build-testing, you could have a simple wrapper like
>>
>> const struct drm_format_info *ipu_format_info(u32 format)
>> {
>> static const struct drm_format_info invalid = {};
>>
>> if (!IS_REACHABLE(CONFIG_DRM))
>> return &invalid;
>>
>> return drm_format_info(format);
>> }
>
> That should work fine. Both ipu_prg_format_supported and
> ipu_prg_channel_configure are only ever called by DRM code.
Ok, in that case, I think we should just make the compilation
of PRE and PRG conditional and leave them out when DRM
is not built-in (be aware of the case of DRM=m, IPU=y).
Arnd