Re: [PATCH] objtool: make orc_types.h headers match

From: Josh Poimboeuf
Date: Tue Jul 25 2017 - 11:49:09 EST


On Tue, Jul 25, 2017 at 05:28:48PM +0200, Arnd Bergmann wrote:
> Building objtool causes a warning on the latest linux-next kernels:
>
> warning: objtool: orc_types.h differs from kernel
>
> From what I can tell, we have two slightly different copies of the same
> header, and we try to ensure they are the same with the warning.

Oops!

> This picks the copy from the x86 headers (without the __packed
> annotation), by roll of dice.

You lost ;-) It should be __packed.

BTW this will also be fixed when the ORC unwinder gets merged, which
will presumably be soon.

> Fixes: 39358a033b2e ("objtool, x86: Add facility for asm code to provide unwind hints")

^^^ This is the one that introduced the bug.

--
Josh