Re: [RESEND PATCH v4 0/2] ZII RAVE platform driver

From: Chris Healy
Date: Tue Jul 25 2017 - 17:06:34 EST


Full series successfully tested on both RDU1 and RDU2 platforms.
Builds and executes correctly.

Tested-by: Chris Healy <cphealy@xxxxxxxxx>


On Tue, Jul 25, 2017 at 11:44 AM, Andrey Smirnov
<andrew.smirnov@xxxxxxxxx> wrote:
> Hi everyone,
>
> This patch series is v4 of the driver for supervisory processor found
> on RAVE series of devices from ZII. Supervisory processor is a PIC
> microcontroller connected to various electrical subsystems on RAVE
> devices whose firmware implements protocol to command/qery them.
>
> Changes since [v3]:
>
> - Re-collected lost Acked-by from Rob
>
> - Incorporated further feedback from Andy Shevchenko
>
> - Dropped useless change (stray newline) to drivers/mfd/Makefile
>
> Changes since [v2]:
>
> - Fixed swapped command codes in rave_sp_common_get_boot_source()
> and rave_sp_common_set_boot_source() revealed by further testing
> of the code
>
> - Incorporated feedback from Andy Shevchenko
>
> Changes since [v1]:
>
> - Updated wording in DT-bindings as per Rob's request.
>
> - Collected Rob's Acked-by for patch 2/2
>
> NOTE:
>
> * The driver for "zii,rave-sp-watchdog" exists, but I haven't
> submitted it yet, becuase I wanted to make sure that API exposed by
> this MFD is acceptable and doesn't need drastic changes.
>
> * This driver is dependent on crc_ccitt_false() introduced in
> 2da9378d531f8cc6670c7497f20d936b706ab80b in 'linux-next'
>
> Feedback is greatly appreciated!
>
> Thanks,
> Andrey Smirnov
>
> [v3] lkml.kernel.org/r/20170724150915.4824-1-andrew.smirnov@xxxxxxxxx
> [v2] lkml.kernel.org/r/20170718175604.11735-1-andrew.smirnov@xxxxxxxxx
> [v1] lkml.kernel.org/r/20170710170449.4544-1-andrew.smirnov@xxxxxxxxx
>
> Andrey Smirnov (2):
> platform: Add driver for RAVE Supervisory Processor
> dt-bindings: mfd: Add bindings for ZII RAVE devices
>
> .../devicetree/bindings/mfd/zii,rave-sp.txt | 39 +
> drivers/platform/Kconfig | 2 +
> drivers/platform/Makefile | 1 +
> drivers/platform/rave/Kconfig | 26 +
> drivers/platform/rave/Makefile | 1 +
> drivers/platform/rave/rave-sp.c | 1126 ++++++++++++++++++++
> include/linux/rave-sp.h | 54 +
> 7 files changed, 1249 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/zii,rave-sp.txt
> create mode 100644 drivers/platform/rave/Kconfig
> create mode 100644 drivers/platform/rave/Makefile
> create mode 100644 drivers/platform/rave/rave-sp.c
> create mode 100644 include/linux/rave-sp.h
>
> --
> 2.13.3
>