Re: [PATCH -mm -v3 1/6] mm, swap: Add swap cache statistics sysfs interface

[Huang\, Ying]

Hi, Rik,

Rik van Riel <riel@xxxxxxxxxx> writes:

> On Tue, 2017-07-25 at 09:51 +0800, Huang, Ying wrote:
>> From: Huang Ying <ying.huang@xxxxxxxxx>
>> 
>> The swap cache stats could be gotten only via sysrq, which isn't
>> convenient in some situation.ÂÂSo the sysfs interface of swap cache
>> stats is added for that.ÂÂThe added sysfs directories/files are as
>> follow,
>> 
>> /sys/kernel/mm/swap
>> /sys/kernel/mm/swap/cache_find_total
>> /sys/kernel/mm/swap/cache_find_success
>> /sys/kernel/mm/swap/cache_add
>> /sys/kernel/mm/swap/cache_del
>> /sys/kernel/mm/swap/cache_pages
>> 
> What is the advantage of this vs new fields in
> /proc/vmstat, which is where most of the VM
> statistics seem to live?

As proposed by Andrew, will use debugfs for them, because they are
mostly developer related.

Best Regards,
Huang, Ying