Re: [PATCH] irqchip: create a Kconfig menu for irqchip drivers

[Marc Zyngier]

On 26/07/17 05:03, Masahiro Yamada wrote:
> Some irqchip drivers have a Kconfig prompt.  When we run menuconfig
> or friends, those drivers are directly listed in the "Device Drivers"
> menu level.  This does not look nice.  Create a sub-system level menu.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> ---
> 
>  drivers/irqchip/Kconfig | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index f1fd5f44d1d4..7b66313a2952 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -1,3 +1,5 @@
> +menu "IRQ chip support"
> +
>  config IRQCHIP
>  	def_bool y
>  	depends on OF_IRQ
> @@ -306,3 +308,5 @@ config QCOM_IRQ_COMBINER
>  	help
>  	  Say yes here to add support for the IRQ combiner devices embedded
>  	  in Qualcomm Technologies chips.
> +
> +endmenu
> 

I'm very reluctant to introduce this. IMHO, interrupt controllers are
way too low level a thing to let them be selected by the user. They
really should be selected by the platform that needs them

Do you have any example in mind where having a user-selectable interrupt
controller actually makes sense on its own?

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...