Re: [PATCH] irqchip: create a Kconfig menu for irqchip drivers

[Masahiro Yamada]

2017-07-26 23:24 GMT+09:00 Thomas Gleixner <tglx@xxxxxxxxxxxxx>:
> On Wed, 26 Jul 2017, Marc Zyngier wrote:
>> On 26/07/17 14:14, Masahiro Yamada wrote:
>> > The irqchip maintainers applied drivers
>> > with user-configurable Kconfig entries.
>>
>> They are *not* user-selectable, since there is *NO* menu entry. *You*
>> are making them user-selectable, and I'm objecting to that.
>
> Masahiro is right. They are user selectable.
>
> Enable CONFIG_SOC_IMX51 and you'll get a prompt for
>
>        TS-4800 IRQ controller
>
> in the middle of the 'Device Drivers' menu. Same for the other options,
> which have prompts. The irqchip Kconfig is included from drivers/Kconfig so
> there is menu context, just not a proper one.
>
> I agree that this is crap and these prompts should be removed and the irq
> thingy selected by the stuff which needs it.



I could not find any corresponding platform that selects CONFIG_TS4800_IRQ.
I am not familiar with this driver at all, but
is this a corner case according to the commit message below?

If the main SoC selects the FPGA IP, it is weird
because this is really board-specific connection.



commit d01f8633d52e4dac5ee598b87d49fd23346ccfd6
Author: Damien Riegel <damien.riegel@xxxxxxxxxxxxxxxxxxxx>
Date:   Mon Dec 21 15:11:23 2015 -0500

    irqchip/ts4800: Add TS-4800 interrupt controller

    This commit adds support for the TS-4800 interrupt controller. This
    controller is instantiated in a companion FPGA, and multiplex interrupts
    for other FPGA IPs.

    As this component is external to the SoC, the SoC might need to reserve
    pins, so this controller is implemented as a platform driver and doesn't
    use the IRQCHIP_DECLARE construct.

    Signed-off-by: Damien Riegel <damien.riegel@xxxxxxxxxxxxxxxxxxxx>
    Cc: Jason Cooper <jason@xxxxxxxxxxxxxx>
    Cc: Marc Zyngier <marc.zyngier@xxxxxxx>
    Cc: Rob Herring <robh+dt@xxxxxxxxxx>
    Cc: Pawel Moll <pawel.moll@xxxxxxx>
    Cc: Mark Rutland <mark.rutland@xxxxxxx>
    Cc: Ian Campbell <ijc+devicetree@xxxxxxxxxxxxxx>
    Cc: Kumar Gala <galak@xxxxxxxxxxxxxx>
    Cc: kernel@xxxxxxxxxxxxxxxxxxxx
    Link: http://lkml.kernel.org/r/1450728683-31416-2-git-send-email-damien.riegel@xxxxxxxxxxxxxxxxxxxx
    Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>






-- 
Best Regards
Masahiro Yamada