Re: [PATCH 2/3] ACPI/DRM: rework ACPI_VIDEO Kconfig dependencies
From: Rafael J. Wysocki
Date: Wed Jul 26 2017 - 14:31:33 EST
On Wednesday, July 26, 2017 03:53:11 PM Arnd Bergmann wrote:
> ACPI_VIDEO keeps causing problems with circular Kconfig dependencies,
> as it depends on a couple of other symbols, and it gets selected by
> drivers that may end up being depending on others.
>
> This is an attempt to simplify this by changing all drivers that
> currently 'select ACPI_VIDEO' to use 'depends on'. This by itself
> simplifies the dependency lists for the other drivers. We make
> ACPI_VIDEO 'default y' to avoid having it turned off for 'make
> oldconfig' users. This should again be fine as x86 users will
> normally want this enabled and the option is not available elsewhere.
>
> I'm moving the 'select BACKLIGHT_CLASS_DEVICE/BACKLIGHT_LCD_SUPPORT'
> into ACPI_VIDEO as a further simplification, those were already
> selected by anything that selected ACPI_VIDEO before.
>
> Changing the INPUT dependency in ACPI_CMPC is necessary to avoid a
> circular dependency with X86_PLATFORM_DEVICES/NOUVEAU.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> drivers/acpi/Kconfig | 5 ++++-
> drivers/gpu/drm/gma500/Kconfig | 6 +-----
> drivers/gpu/drm/i915/Kconfig | 7 +------
> drivers/gpu/drm/nouveau/Kconfig | 10 ++--------
> drivers/platform/x86/Kconfig | 6 ++----
> 5 files changed, 10 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
> index 1ce52f84dc23..a8f5a40e2914 100644
> --- a/drivers/acpi/Kconfig
> +++ b/drivers/acpi/Kconfig
> @@ -182,9 +182,12 @@ config ACPI_BUTTON
>
> config ACPI_VIDEO
> tristate "Video"
> - depends on X86 && BACKLIGHT_CLASS_DEVICE
> + depends on X86
> depends on INPUT
> select THERMAL
> + select BACKLIGHT_CLASS_DEVICE
> + select BACKLIGHT_LCD_SUPPORT
> + default y
> help
> This driver implements the ACPI Extensions For Display Adapters
> for integrated graphics devices on motherboard, as specified in
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
for the ACPI_VIDEO changes.
Thanks,
Rafael