Re: [PATCH 3/3] EDAC, ghes: Make it a proper module

[Kani, Toshimitsu]

On Wed, 2017-07-26 at 07:24 -0300, Mauro Carvalho Chehab wrote:
> Em Wed, 26 Jul 2017 10:48:27 +0200
> Borislav Petkov <bp@xxxxxxxxx> escreveu:
> 
> > From: Borislav Petkov <bp@xxxxxxx>
> > 
> > Register with the GHES notifier chain so that there's no need to
> > call into the module with ghes_edac_report_mem_error().
> 
> Hmm... I'm not seeing any implementation that would allow setting
> between firmware first, hardware first or "auto", as we've discussed.

A minor nit for terminology - hardware is always the first one to
detect an error.  The difference is whether an error is first reported
to the kernel or firmware.  So, "kernel first" or "os first" would be
more appropriate as an alternative to "firmware first".  That said,
such wording may be misleading since it does not change the mode.

Thanks,
-Toshi