Re: [PATCH 2/2] drm/msm: gpu: don't abuse dma_alloc for non-DMA allocations

[Arnd Bergmann]

 On Jul 26, 2017 6:35 PM, "Jordan Crouse" <jcrouse@xxxxxxxxxxxxxx> wrote:

> >       if (!IS_ENABLED(CONFIG_ARCH_QCOM))
> >               return -EINVAL;
> >
> > +     np = of_get_child_by_name(dev->of_node, "zap-shader");
> > +     if (!np)
> > +             return -ENODEV;
> > +
> > +     np = of_parse_phandle(dev->of_node, "memory-region", 0);
>
> I think this should be np = of_parse_phandle(np, "memory-region", 0);
>

Ok, fixed.

> > @@ -373,44 +393,6 @@ static int a5xx_zap_shader_resume(struct msm_gpu *gpu)
> >  }
> >
> >  /* Set up a child device to "own" the zap shader */
>
> This now incorrect comment can be zapped (pun intended).

Done.

> > -static int a5xx_zap_shader_dev_init(struct device *parent, struct device *dev)
> > -{
> > -     struct device_node *node;
> > -     int ret;
> > -
> > -     if (dev->parent)
> > -             return 0;
> > -
>
> With above changes,
> Acked-and-Tested-By: Jordan Crouse <jcrouse@xxxxxxxxxxxxxx>

Thanks for testing!

I've re-sent this patch as v3 now (this one was actually v2, depending on
how you count). I decided not to resend patch 1/2 of the series. We still
need that too, but they are independent. Hope that's ok.