Re: [PATCHv3 1/6] ALSA: pcm: Export soc_dpcm_runtime_update

[Sebastian Reichel]

Hi,

On Tue, Jul 25, 2017 at 05:42:59PM +0200, Takashi Iwai wrote:
> On Tue, 25 Jul 2017 17:10:25 +0200,
> Sebastian Reichel wrote:
> > Some codecs may need to use this from loadable modules. Without
> > this patch compilation for this kind of codec will fail with the
> > following error:
> > 
> > ERROR: "soc_dpcm_runtime_update" [sound/soc/codecs/snd-soc-cpcap.ko]
> > undefined!
> > 
> > Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>
> > Signed-off-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxxxx>
> 
> If you do export the function, please make its comments prettier, so
> that it appears in kernel documentation properly as an API function.
> 
> Also, in general, we use snd_ prefix for the exported stuff.
> You'd need to rename it accordingly, too.
> 
> Last but not least, this is specific to ASoC, so use "ASoC" prefix to
> the subject line.

After fixing this locally I noticed, that I no longer need to call
soc_dpcm_runtime_update at all and it can remain private. So this
patch will be dropped in v4.

-- Sebastian

Attachment: signature.asc
Description: PGP signature