Re: [PATCHv2 1/2] dt-bindings: backlight: add ti-lmu-backlight binding

[Sebastian Reichel]

Hi,

On Mon, Jul 24, 2017 at 11:58:26AM -0500, Rob Herring wrote:
> On Mon, Jul 17, 2017 at 03:39:55PM +0200, Sebastian Reichel wrote:
> > +Required property:
> > + - compatible: Should be one of:
> > +        "ti,lm3532-backlight"
> > +        "ti,lm3631-backlight"
> > +        "ti,lm3632-backlight"
> > +        "ti,lm3633-backlight"
> > +        "ti,lm3695-backlight"
> > +        "ti,lm3697-backlight"
> 
> Some of the parts only do backlight, so drop the "-backlight" on those. 
> And having a sub-node makes no sense in that case. Perhaps it should be 
> 2 binding documents separating the single function devices and MFDs. The 
> binding doc(s) doesn't have to align with the driver(s). You can have 1 
> driver serve 2 bindings.

Yes, there is LM3532 and LM3695, which is backlight only as far as I
can see. Your suggestion contradicts with existing binding, though:

Documentation/devicetree/bindings/mfd/ti-lmu.txt

-- Sebastian

Attachment: signature.asc
Description: PGP signature