[PATCH v4 8/9] perf annotate: Check total period before calculating percent
From: Taeung Song
Date: Thu Jul 27 2017 - 12:16:51 EST
Before calculating percent, checking total period
is clear and safer than checking just number of samples.
So fix it.
Cc: Jiri Olsa <jolsa@xxxxxxxxxx>
Cc: Namhyung Kim <namhyung@xxxxxxxxxx>
Signed-off-by: Taeung Song <treeze.taeung@xxxxxxxxx>
---
tools/perf/util/annotate.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 7032bdc..522b67b 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
@@ -967,7 +967,7 @@ double disasm__calc_percent(struct annotation *notes, int evidx, s64 offset,
period += h->addr[offset++].period;
}
- if (h->nr_samples) {
+ if (h->period) {
sample->period = period;
sample->nr_samples = hits;
percent = 100.0 * hits / h->nr_samples;
@@ -1718,7 +1718,7 @@ static int symbol__get_source_line(struct symbol *sym, struct map *map,
h = annotation__histogram(notes, evidx + k);
nr_samples = h->addr[i].nr_samples;
- if (h->nr_samples)
+ if (h->period)
percent = 100.0 * nr_samples / h->nr_samples;
if (percent > percent_max)
--
2.7.4