Re: [PATCH v3 04/10] cpufreq: dt: invoke frequency-invariance setter function

From: Viresh Kumar
Date: Fri Jul 28 2017 - 04:25:46 EST


On 27-07-17, 20:33, Dietmar Eggemann wrote:
> Call the frequency-invariance setter function arch_set_freq_scale()
> if the new frequency has been successfully set which is indicated by
> dev_pm_opp_set_rate() returning 0.
>
> Cc: Rafael J. Wysocki <rjw@xxxxxxxxxxxxx>
> Cc: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> Signed-off-by: Dietmar Eggemann <dietmar.eggemann@xxxxxxx>
> ---
> drivers/cpufreq/cpufreq-dt.c | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c
> index fef3c2160691..cbac8a7dbc50 100644
> --- a/drivers/cpufreq/cpufreq-dt.c
> +++ b/drivers/cpufreq/cpufreq-dt.c
> @@ -43,9 +43,17 @@ static struct freq_attr *cpufreq_dt_attr[] = {
> static int set_target(struct cpufreq_policy *policy, unsigned int index)
> {
> struct private_data *priv = policy->driver_data;
> + unsigned long freq = policy->freq_table[index].frequency;
> + int ret;
> +
> + ret = dev_pm_opp_set_rate(priv->cpu_dev, freq * 1000);
>
> - return dev_pm_opp_set_rate(priv->cpu_dev,
> - policy->freq_table[index].frequency * 1000);
> + if (!ret) {
> + arch_set_freq_scale(policy->related_cpus, freq,
> + policy->cpuinfo.max_freq);
> + }
> +
> + return ret;
> }

Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

--
viresh