Re: [PATCH v1 3/6] ASoC: codecs: msm8916-wcd-analog: move codec reset to probe

From: Srinivas Kandagatla
Date: Fri Jul 28 2017 - 10:06:50 EST




On 28/07/17 14:40, Mark Brown wrote:
On Wed, Jul 26, 2017 at 02:35:09AM +0200, srinivas.kandagatla@xxxxxxxxxx wrote:
From: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>

This patch move the codec reset code from dai ops to codec probe, so
that the codec is not held in reset when headset detection block is
still active.

This means that the CODEC will no longer be held in reset (which
presumably has a power benefit or something) even if jack detection
isn't in use. What most devices do is have things like this be
controlled via the bias level or other power management functions and
then have jack detection hold the CODEC out of the lowest power states
when it's active.

This chip has two power sources for MBHC logic, one from mic bias which is used when we have active audio usecase, and other from internal current source which is for low-power state when no audio use case is active.

By default with the existing code uses internal current source which puts chip in low power state.