Re: [PATCH 0/3] selftests: sync test conversion to TAP13

[Gustavo Padovan]

Hi Shuah,

Thank you for your patches.

On Mon, 2017-07-24 at 15:07 -0600, Shuah Khan wrote:
> This patch series includes patches to convert sync test to use TAP13
> ksft framework. In addition, fix to sync test to differentiate
> between
> unsupported feature and access error when a non-root user runs it.
> 
> Updated kfst framework to return counters for sync test to use to
> print
> the final pass or fail summary message. Updated ksft+print_cnts() to
> print counters to summarize the test results.
> 
> Shuah Khan (3):
> Â selftests: sync: differentiate between sync unsupported and access
> ÂÂÂÂerrors
> Â selftests: kselftest framework: add API to return pass/fail/*
> counts
> Â selftests: sync: convert to use TAP13 ksft framework
> 
> Âtools/testing/selftests/kselftest.hÂÂÂÂÂÂ| 10 +++++
> Âtools/testing/selftests/sync/sync_test.c | 71 +++++++++++++++++++++-
> ----------
> Âtools/testing/selftests/sync/synctest.hÂÂ|ÂÂ3 +-
> Â3 files changed, 58 insertions(+), 26 deletions(-)

All looks good to me, so for the 3 patches:
Reviewed-by: Gustavo Padovan <gustavo.padovan@xxxxxxxxxxxxx>

	Gustavo

-- 
Gustavo Padovan
Collabora Ltd.