Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly

[Egil Hjelmeland]

Den 28. juli 2017 19:05, skrev Florian Fainelli:
> On 07/28/2017 09:55 AM, Vivien Didelot wrote:
> > Hi Egil,
> >
> > Egil Hjelmeland <privat@xxxxxxxxxxxxxxxxxx> writes:
> >
> > > > > +const struct lan9303_phy_ops lan9303_indirect_phy_ops = {
> > > > > +	.phy_read = lan9303_indirect_phy_read,
> > > > > +	.phy_write = lan9303_indirect_phy_write,
> > > > > +};
> > > > > +EXPORT_SYMBOL(lan9303_indirect_phy_ops);
> > > >
> > > > Isn't EXPORT_SYMBOL_GPL prefered over EXPORT_SYMBOL?
> > >
> > > I have no opinion. I just used the same variant as the other EXPORTS
> > > in the file.
> >
> > If there is no concern from others about this, LGTM too:
>
> Since the kernel module license is GPL, EXPORT_SYMBOL_GPL() would seem
> to be appropriate, which can be done as a subsequent patch.
>
> Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
I have no idea how these legalities work. But for the record,
I give consent to change to EXPORT_SYMBOL_GPL at any time.

Egil Hjelmeland