Re: [PATCH 0/3] remove rw_page() from brd, pmem and btt
From: Minchan Kim
Date: Mon Jul 31 2017 - 03:40:26 EST
On Mon, Jul 31, 2017 at 09:17:07AM +0200, Christoph Hellwig wrote:
> On Mon, Jul 31, 2017 at 07:16:59AM +0900, Minchan Kim wrote:
> > rw_page's gain is reducing of dynamic allocation in swap path
> > as well as performance gain thorugh avoiding bio allocation.
> > And it would be important in memory pressure situation.
>
> There is no need for any dynamic allocation when using the bio
> path. Take a look at __blkdev_direct_IO_simple for an example
> that doesn't do any allocations.
Do you suggest define something special flag(e.g., SWP_INMEMORY)
for in-memory swap to swap_info_struct when swapon time manually
or from bdi_queue_someting automatically?
And depending the flag of swap_info_struct, use the onstack bio
instead of dynamic allocation if the swap device is in-memory?