Re: [PATCH net-next 0/2] Refactor lan9303_xxx_packet_processing

[Egil Hjelmeland]

On 31. juli 2017 15:22, Andrew Lunn wrote:
> On Mon, Jul 31, 2017 at 01:33:53PM +0200, Egil Hjelmeland wrote:
> > First patch:
> > Change lan9303_enable_packet_processing,
> > lan9303_disable_packet_processing():
> > Pass port number (0,1,2) as parameter instead of port offset.
> > Plus replaced a constant 0x400 with LAN9303_SWITCH_PORT_REG()
>
> Hi Egil
>
> The cover note and the commit message should concentrate on the Why,
> not the What. I can see the What by reading the patch.
>
> Why do you want to pass port numbers?
Because other functions in the module pass port numbers. And to enable
the simplifications.

> Note that for netdev, the cover note also ends up in git as part of
> the history.

OK, I did not know that netdev does that.

>     Andrew