RE: [PATCH V5 net-next 7/8] net: hns3: Add Ethtool support to HNS3 driver

[Salil Mehta]

Hi Andrew,

> -----Original Message-----
> From: Salil Mehta
> Sent: Saturday, July 29, 2017 12:57 AM
> To: 'Andrew Lunn'
> Cc: davem@xxxxxxxxxxxxx; Zhuangyuzeng (Yisen); huangdaode; lipeng (Y);
> mehta.salil.lnk@xxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx; Linuxarm
> Subject: RE: [PATCH V5 net-next 7/8] net: hns3: Add Ethtool support to
> HNS3 driver
> 
> Hi Andrew,
> 
> > -----Original Message-----
> > From: Andrew Lunn [mailto:andrew@xxxxxxx]
> > Sent: Saturday, July 29, 2017 12:49 AM
> > To: Salil Mehta
> > Cc: davem@xxxxxxxxxxxxx; Zhuangyuzeng (Yisen); huangdaode; lipeng
> (Y);
> > mehta.salil.lnk@xxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-
> > kernel@xxxxxxxxxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx; Linuxarm
> > Subject: Re: [PATCH V5 net-next 7/8] net: hns3: Add Ethtool support
> to
> > HNS3 driver
> >
> > On Fri, Jul 28, 2017 at 11:26:51PM +0100, Salil Mehta wrote:
> > > +static const struct hns3_link_mode_mapping hns3_lm_map[] = {
> > > +	{HNS3_LM_FIBRE_BIT, ETHTOOL_LINK_MODE_FIBRE_BIT, FLG},
> > > +	{HNS3_LM_AUTONEG_BIT, ETHTOOL_LINK_MODE_Autoneg_BIT, FLG},
> > > +	{HNS3_LM_TP_BIT, ETHTOOL_LINK_MODE_TP_BIT, FLG},
> > > +	{HNS3_LM_PAUSE_BIT, ETHTOOL_LINK_MODE_Pause_BIT, FLG},
> > > +	{HNS3_LM_BACKPLANE_BIT, ETHTOOL_LINK_MODE_Backplane_BIT, FLG},
> > > +	{HNS3_LM_10BASET_HALF_BIT, ETHTOOL_LINK_MODE_10baseT_Half_BIT,
> > FLG},
> > > +	{HNS3_LM_10BASET_FULL_BIT, ETHTOOL_LINK_MODE_10baseT_Full_BIT,
> > FLG},
> > > +	{HNS3_LM_100BASET_HALF_BIT, ETHTOOL_LINK_MODE_100baseT_Half_BIT,
> > FLG},
> > > +	{HNS3_LM_100BASET_FULL_BIT, ETHTOOL_LINK_MODE_100baseT_Full_BIT,
> > FLG},
> > > +	{HNS3_LM_1000BASET_FULL_BIT,
> > ETHTOOL_LINK_MODE_1000baseT_Full_BIT, FLG},
> > > +};
> >
> > It seems like all entries have link_mode_ksettings set to FLG. Which
> > probably indicates it is pointless.
> It is to support SUPPORTED and ADVERTISED link modes.
I can see what you are saying now. Will remove FLG in next patch.

Thanks
Salil