Re: [PATCH v1] i2c: aspeed: fixed potential null pointer dereference

From: Brendan Higgins
Date: Mon Jul 31 2017 - 14:20:49 EST


On Mon, Jul 31, 2017 at 2:27 AM, Joel Stanley <joel@xxxxxxxxx> wrote:
> On Sat, Jul 29, 2017 at 10:30 AM, Brendan Higgins
> <brendanhiggins@xxxxxxxxxx> wrote:
>> Before I skipped null checks when the master is in the STOP state; this
>> fixes that.
>>
>> Signed-off-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx>
>
> Acked-by: Joel Stanley <joel@xxxxxxxxx>
>
> Out of interest, was this found by code review, or did you hit this in testing?

I am pretty sure we hit it in testing. Unfortunately, we had trouble reproducing
it, but we did see a null pointer dereference.

>
> Cheers,
>
> Joel