Re: [PATCH] fbcon: Use background color for margins

[Adam Borowski]

On Mon, Jul 31, 2017 at 12:25:28PM -0500, David Lechner wrote:
> On 07/30/2017 04:51 PM, Pavel Machek wrote:
> > > > > Screens that don't have a black border around the active area will have
> > > > > ugly black bars for the margin when the text background color is not black.
> > > > > This is especially noticeable on an LCD screen (not the backlit kind) when
> > > > > the terminal colors are inverted.

Also when you have multiple monitors of different resolutions (VT does
mirror them which is quite pointless, but hey, VT is meant for rescue tasks
so for fancy features you'd better use X).

I see this on nouveau which your patch doesn't handle, but we can extend it
to nouveau later.

> Ah. I see what you mean now. The margin will be whatever is set for the
> vc_video_erase_char in the kernel, which can be changed by userspace. I
> tried midnight commander and sure enough, I still have the black margins
> when I invert the screen (`setterm -inverse on`). Interestingly, after
> allowing the console to blank after a timeout, the console was blanked with
> white, then after pressing a key to unblank, the margins were also white.

"setterm -inverse on" looks ugly.

I've just added reverse to my vtgamma (https://github.com/kilobyte/vtgamma),
it uses a different method (setting the palette instead of \e[?5h) which on
VT looks a lot nicer.


Meow!
-- 
âââââââ What Would Jesus Do, MUD/MMORPG edition:
âââââââ â multiplay with an admin char to benefit your mortal
âââââââ â abuse item cloning bugs (the five fishes + two breads affair)
âââââââ â use glitches to walk on water